Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in upstream changes via Develop #11

Merged
merged 27 commits into from
Mar 14, 2024
Merged

Pull in upstream changes via Develop #11

merged 27 commits into from
Mar 14, 2024

Conversation

thoraj
Copy link

@thoraj thoraj commented Mar 14, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

RiotRobot and others added 26 commits March 5, 2024 14:05
…#12321)

* Remove references to internal js-sdk type `CryptoBackend`

* Use `Paramteters` to avoid `ts-ignore`
…nt (matrix-org#12320)

* Use `strong` element to semantically denote visually emphasised content

Signed-off-by: Michael Telatynski <[email protected]>

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Add comment

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
It is unused as of matrix-org#12246. I noticed this while working on matrix-org#12299.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update dependency @vector-im/compound-web to v3.1.3

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Update snapshots

Signed-off-by: Michael Telatynski <[email protected]>

* Fix TAC width due to compound update (matrix-org#12326)

---------

Signed-off-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
…r via the EC SPA (matrix-org#12259)

* Add externall call link button if in public call room

Signed-off-by: Timo K <[email protected]>

* Allow configuring a spa homeserver url.

Signed-off-by: Timo K <[email protected]>

* temp

Signed-off-by: Timo K <[email protected]>

* remove homeserver url

Signed-off-by: Timo K <[email protected]>

* Add custom title to share dialog.
So that we can use it as a "share call" dialog.

Signed-off-by: Timo K <[email protected]>

* - rename config options
- only show link button if a guest url is provided
- share dialog custom Title
- rename call share labels

Signed-off-by: Timo K <[email protected]>

* rename to title_link

Signed-off-by: Timo K <[email protected]>

* add tests for ShareDialog

Signed-off-by: Timo K <[email protected]>

* add tests for share call button

Signed-off-by: Timo K <[email protected]>

* review

Signed-off-by: Timo K <[email protected]>

* remove comment

Signed-off-by: Timo K <[email protected]>

* Update src/components/views/dialogs/ShareDialog.tsx

Co-authored-by: David Baker <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>
Co-authored-by: David Baker <[email protected]>
* Fix spotlight opening in TAC

* Add tests

* Remove `RovingTabIndexProvider`
…-org#12319)

* Reset power selector on API failure to prevent state mismatch

Signed-off-by: Michael Telatynski <[email protected]>

* Allow onChange to be sync or async

Signed-off-by: Michael Telatynski <[email protected]>

* Add unmounted check

Signed-off-by: Michael Telatynski <[email protected]>

* Improve coverage

Signed-off-by: Michael Telatynski <[email protected]>

* Iterate

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
…ions (matrix-org#12306)

* Improve Forward Dialog a11y by switching to roving tab index interactions

Signed-off-by: Michael Telatynski <[email protected]>

* Improve screen reader readout

Signed-off-by: Michael Telatynski <[email protected]>

* Improve screen reader readout

Signed-off-by: Michael Telatynski <[email protected]>

* Add tests

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
* Fix CSS & component typo

* Update snapshots
…eLoad=false`) (matrix-org#12292)

* show loading spinner also if waitForIframeLoad = false
Configure EC so it waits for the content loaded action
!WARNING This breaks compatibility with the full mesh branch.
I would like to discuss here if/when we can do that.

Signed-off-by: Timo K <[email protected]>

* stop show loading screen on widget ready (instead of preparing)

Signed-off-by: Timo K <[email protected]>

* wait until widget loading is over before comparing screenshots

Signed-off-by: Timo K <[email protected]>

* fix waitForIFrame=true widgets

Signed-off-by: Timo K <[email protected]>

* test

Signed-off-by: Timo K <[email protected]>

* always start with loading true. + cleanup

Signed-off-by: Timo K <[email protected]>

* simplify loading

Signed-off-by: Timo K <[email protected]>

* update snapshots (start not in loading state for waitForIframe = true widgets)

Signed-off-by: Timo K <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>
* Refine styles of menus, toasts, popovers, and modals

This is a reintroduction of matrix-org#12247, with the difference that modal styles have now been refreshed as well.

* Restore the fixed heights of some dialogs

* Fix formatting and flaky screenshot
…ges (matrix-org#12295)

* update widget url when the theme changes

Signed-off-by: Timo K <[email protected]>

* quick "make it EC specific" workaround proposal.

Signed-off-by: Timo K <[email protected]>

* use `matches`

Signed-off-by: Timo K <[email protected]>

* test coverage

Signed-off-by: Timo K <[email protected]>

* more test coverage

Signed-off-by: Timo K <[email protected]>

* fix jest

Signed-off-by: Timo K <[email protected]>

* add tests for theme changes

Signed-off-by: Timo K <[email protected]>

* update snapshots

Signed-off-by: Timo K <[email protected]>

* test for theme update with non ec widget

Signed-off-by: Timo K <[email protected]>

* add dark custom theme widget url

Signed-off-by: Timo K <[email protected]>

* trigger conditions for theme cleanup

Signed-off-by: Timo K <[email protected]>

* update tests using testId

Signed-off-by: Timo K <[email protected]>

* use typed event emitter for theme watcher

Signed-off-by: Timo K <[email protected]>

* simplify condition

Signed-off-by: Timo K <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>
@thoraj thoraj added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 14, 2024
@thoraj thoraj marked this pull request as ready for review March 14, 2024 09:20
@thoraj
Copy link
Author

thoraj commented Mar 14, 2024

Not sure why the test fails, but the error indicates some kind of async problem with the test itself. In the interest of keeping the three repos verji-develop synced, I will merge even with a failing check

@thoraj thoraj merged commit 1a31c8c into verji-develop Mar 14, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants